Conversation
…ted state management
…als tables using useEffect
…mic page visibility
…al count for apps, datasets, and workerpools
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ockchainComputing/explorer-v2 into feature/add-assets-order
…and SchemaSearch components
… in Footer, Navbar, and AddressChip
…k Explorer link in SmartLinkGroup; add role to Tabs component
…and attributes to input and error messages
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| left: `${indicatorStyle.left}px`, | ||
| width: `${indicatorStyle.width}px`, | ||
| }} | ||
| role="tablist" |
There was a problem hiding this comment.
Tablist role placed on wrong element
Medium Severity
The role="tablist" attribute is added to a decorative indicator <div> that visually shows the active tab selection. This div has no children and is purely for visual styling. The actual <Button> elements with role="tab" are rendered as siblings, not children of this tablist. According to ARIA specifications, tab elements must be owned by or contained within the tablist. The role="tablist" belongs on the outer container div (the one with ref={containerRef}) that actually holds the tab buttons.
… are installed before checks
…l and enhancing main.yml
|
|
||
| // Verify that the TASKS tab is visible | ||
| await expect(page.getByRole('tab', { name: 'TASKS' })).toBeVisible(); | ||
| await expect(page.getByRole('tab', { name: 'TASKS' })).toBeVisible(); |
There was a problem hiding this comment.
Duplicate test assertion for TASKS tab visibility
Low Severity
Both test files contain identical duplicate assertions checking for TASKS tab visibility on consecutive lines. The same expect(page.getByRole('tab', { name: 'TASKS' })).toBeVisible() appears twice in a row, which appears to be a copy-paste error that doesn't add any test value.
Additional Locations (1)
…nd Playwright tests
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Christophe-iExec
left a comment
Christophe-iExec
left a comment
There was a problem hiding this comment.
LGTM to add playwright functional tests in the CI process , even if war from perfect
2 participants
Note
Medium Risk
Adds Playwright browser tests and runs them on every PR/branch CI build, increasing CI runtime and introducing potential flakiness due to reliance on live app data and hardcoded IDs/URLs.
Overview
Adds Playwright end-to-end coverage for key unauthenticated flows (homepage tables, search behavior, list pages, and deal/task detail tabs) via new specs under
tests/unlogged/and a newplaywright.config.tswith multi-browser projects and a VitewebServer.Updates CI to run
codegen, build, install Playwright browsers, execute Playwright tests, and upload the HTML report artifact; also adds@playwright/test+npm testscript and ignores Playwright output directories in.gitignore.Written by Cursor Bugbot for commit cf5474f. This will update automatically on new commits. Configure here.